Loading

Unfortunate design flaw, Send to: All

General Discussion around Collabtive

Unfortunate design flaw, Send to: All

Postby Caps » 25.10.2011, 23:10

The flaw is allowing a message to default to: "All," can be quite embarrassing if a communication is sent to the wrong party. Basic stuff, why has this not be corrected?

Better to have a tick toggle with all options unticked or unchecked. The many parts that are grand and you have this. Tell me where I can modify the script.
Caps
 
Posts: 34
Joined: 21.10.2011, 00:40

Re: Unfortunate design flaw, Send to: All

Postby Eva » 26.10.2011, 17:23

Basic stuff, why has this not be corrected?


Uhm, sorry, but don't you think your attitude is a bit ... snotty?

This was a design decision. If the user selects the wrong recipient(s), it's his fault.
User avatar
Eva
 
Posts: 833
Joined: 01.01.2008, 23:31
Location: Saarbrücken, Germany

Re: Unfortunate design flaw, Send to: All

Postby Caps » 26.10.2011, 22:05

[...edited by administration...] It is indeed a design flaw no matter how many voted. This is not new, good policies do not allow the default to step on the pedal full force. The outcome is that you can loose a client or co-worker for accidentally clicking on send. If you have not ventured outside, you would not be aware of this.
Caps
 
Posts: 34
Joined: 21.10.2011, 00:40

Re: Unfortunate design flaw, Send to: All

Postby Philipp » 26.10.2011, 22:22

Caps wrote:A staff member with that kind of a response is not professional. It is indeed a design flaw no matter how many voted. This is not new, good policies do not allow the default to step on the pedal full force. The outcome is that you can loose a client or co-worker for accidentally clicking on send. If you have not ventured outside, you would not be aware of this.


I don't think this is as fundamental an issue as you make it out to be.
I think this is a matter of preference, and i like it the way it is.

Also, no one has ever complained about this before.
To change this behaviour, you need to modify the form templates in /templates/standard/

Philipp
Lead developer
User avatar
Philipp
Site Admin
 
Posts: 969
Joined: 14.12.2007, 03:06
Location: Saarbrücken, germany

Re: Unfortunate design flaw, Send to: All

Postby Caps » 27.10.2011, 00:38

Thank you Philipp.
Caps
 
Posts: 34
Joined: 21.10.2011, 00:40

Re: Unfortunate design flaw, Send to: All

Postby Caps » 27.10.2011, 20:17

May I ask if you would give me the file and line number where I could make that change.
Caps
 
Posts: 34
Joined: 21.10.2011, 00:40

Re: Unfortunate design flaw, Send to: All

Postby some person » 28.10.2011, 00:56

Caps wrote:May I ask if you would give me the file and line number where I could make that change.

Here is something I came up with.

In addmessageform.tpl, replace lines 100 to 103 with the following.
Code: Select all
            <select name = "sendto[]" multiple style = "height:100px;" required="1" realname="Notify">
               <option value = "" disabled style = "color:black;font-weight:bold;">{#general#}</option>
               <option value = "all">{#all#}</option>

What I have done there is I have removed the select from all option. This makes it so there is no selection, and you will have to make one each time. Next I added required to the notify options list, this makes it so that it triggers the javascript validation, so if you were to forget to select an option you will get notified.

Now there is a valid reason to changing this. My changes make it so that if the users were to forget the notify options list, he would get notified to select an option. As it is now, the default behavior, if the user were to forget about the notification option, which there is a chance to happen, the users would send an email notification to all, and maybe the user didn't mean, or want to send to all.
Have any Bitcoins (http://weusecoins.com) found my post helpful, you can send a tip to the following bitcoin address found on http://btc.to/a9n.
some person
 
Posts: 363
Joined: 16.04.2011, 12:46

Re: Unfortunate design flaw, Send to: All

Postby Caps » 21.06.2012, 10:58

Wow, did not say, thank you. Thank you for your assistance.
Caps
 
Posts: 34
Joined: 21.10.2011, 00:40


Return to General

Who is online

Users browsing this forum: No registered users