Loading

Message replies blank

Get help with problems, or report & discuss bugs in Collabtive

Message replies blank

Postby Wroth » 20.04.2016, 00:37

Hello,

Reporting a fairly significant bug that deletes message reply content, very specific and reproducible steps.

On a message's page if at least one reply already exists, then using the 'reply' arrow [at the top of the message page by the title] to reply to a message will leave your reply body blank. The title and other meta data posts fine, but the body is blank. Blank in email notification as well. Using the "answer" and "+" buttons to add a reply to the message works fine, reply body is retained. Using the reply arrow button from the main Messages page is also fine.

The bug is tied specifically to the arrow button on the message's page, and only happens after there is at least one reply. This is with Collabtive 2.1, reproduced on the demo installation, as well as my own.

Quickest solution is probably just hiding that button once there is at lest one reply on the page. Does anyone have a recommendation how to do that conditional hiding?

Having a client's reply content become blank if they happen to click the wrong button, which they have a 1/4 chance of doing, is a pretty large issue imho.
Wroth
 
Posts: 12
Joined: 19.04.2016, 23:43

Re: Message replies blank

Postby Wroth » 22.04.2016, 23:33

Since this was such a potentially harmful bug for me, I went ahead and built a temporary workaround with some css in the theme style file. The following line hides the first item of the message menu if there are at lest three items on that menu.

Code: Select all
.msgs .statuswrapper ul li:first-child:nth-last-child(3) {display: none}


Initially on a message with no replies, there are only two items, so the reply button will show at this stage - the button works at that stage so it's safe to show. Once one reply has been entered the button will break and delete entered body text, at the same time a new child of the menu appears the count of replies. Using the appearance of the replies item to determine if there are replies on the message is the trigger for hiding the dangerous reply button. Users can reply with the two buttons lower down the page still of course, which are safe.

That is the concept behind this workaround anyhow, so far in testing this has worked as intended but depending on the browser the css involved here may not be supported so use with caution. Hopefully this workaround is helpful until this bug is actually patched out.
Wroth
 
Posts: 12
Joined: 19.04.2016, 23:43

Re: Message replies blank

Postby Eva » 23.04.2016, 11:44

Confirmed.
We will fix this bug for the next release. Thank you for reporting it!
Project Management the way you like it: Collaborative - Open Source - Free

facebook.com/Collabtive
twitter.com/Collabtive
xing.com/companies/collabtive
linkedin.com/company/collabtive
User avatar
Eva
 
Posts: 1471
Joined: 01.01.2008, 23:31
Location: Saarbrücken, Germany

Re: Message replies blank

Postby Wroth » 25.04.2016, 22:59

Awesome news, thanks!
Wroth
 
Posts: 12
Joined: 19.04.2016, 23:43

Re: Message replies blank

Postby Philipp » 20.05.2016, 07:01

Fixed for next release.

Here the diff:
https://github.com/philippK-de/Collabti ... 11be93f7e5
User avatar
Philipp
Site Admin
 
Posts: 1118
Joined: 14.12.2007, 03:06
Location: Saarbrücken, germany

Re: Message replies blank

Postby Wroth » 02.06.2016, 23:45

Philipp wrote:Fixed for next release.

Here the diff:
https://github.com/philippK-de/Collabti ... 11be93f7e5


Thank you for your work addressing this, as well as some of the other bugs that were troubling me.
Wroth
 
Posts: 12
Joined: 19.04.2016, 23:43

Re: Message replies blank

Postby Philipp » 08.09.2016, 19:43

A lot of progress was made on messages for 3.0 overall.
Aside from fixing many bugs, recursive replies are now supported as well.

Collabtive 3.0 will be released soon.
User avatar
Philipp
Site Admin
 
Posts: 1118
Joined: 14.12.2007, 03:06
Location: Saarbrücken, germany


Return to Problems and Bugs

Who is online

Users browsing this forum: No registered users

cron